From 5427666ff97126bfd958bcecef5db364f3ecae65 Mon Sep 17 00:00:00 2001 From: Ruben Hensen Date: Fri, 23 Oct 2026 17:03:32 +0200 Subject: [PATCH] longhorn: list Argo CD's pre-delete finalizers Argo CD 3.x adds pre-delete-finalizer.argocd.argoproj.io and its /cleanup variant to Applications with PreDelete hooks, which the Longhorn chart has. With only resources-finalizer in git, the apps app-of-apps stayed OutOfSync on helm-longhorn. --- apps/templates/longhorn-helm.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/apps/templates/longhorn-helm.yaml b/apps/templates/longhorn-helm.yaml index 350941d..c434be2 100644 --- a/apps/templates/longhorn-helm.yaml +++ b/apps/templates/longhorn-helm.yaml @@ -5,6 +5,10 @@ metadata: namespace: argocd finalizers: - resources-finalizer.argocd.argoproj.io + # Argo CD 3.x adds these for apps with PreDelete hooks (the Longhorn + # chart has one). Listed here so the parent app doesn't see a diff. + - pre-delete-finalizer.argocd.argoproj.io + - pre-delete-finalizer.argocd.argoproj.io/cleanup spec: syncPolicy: syncOptions: